Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tune/CI] Fix Tune-Pytorch-CIFAR notebook example #26474

Merged
merged 3 commits into from
Jul 13, 2022
Merged

[Tune/CI] Fix Tune-Pytorch-CIFAR notebook example #26474

merged 3 commits into from
Jul 13, 2022

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Jul 12, 2022

Signed-off-by: Antoni Baum [email protected]

Why are these changes needed?

Fixes the Tune-Pytorch-CIFAR notebook example as found in #26410

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Yard1 Yard1 added this to the Ray AIR milestone Jul 12, 2022
@Yard1 Yard1 requested a review from maxpumperla as a code owner July 12, 2022 18:24
@krfricke krfricke merged commit e48d381 into ray-project:master Jul 13, 2022
@Yard1 Yard1 deleted the fix_tune_pytorch_cifar_notebook branch July 13, 2022 12:44
@brucez-anyscale brucez-anyscale mentioned this pull request Jul 14, 2022
Merged
6 tasks
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
@Yard1
[Tune/CI] Fix Tune-Pytorch-CIFAR notebook example (ray-project#26474)
3cb0848 
Fixes the Tune-Pytorch-CIFAR notebook example as found in ray-project#26410

Signed-off-by: Antoni Baum <[email protected]>
Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xwjiang2010 xwjiang2010 xwjiang2010 approved these changes

@richardliaw richardliaw richardliaw approved these changes

@krfricke krfricke Awaiting requested review from krfricke

@amogkam amogkam Awaiting requested review from amogkam

@matthewdeng matthewdeng Awaiting requested review from matthewdeng matthewdeng is a code owner

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

Assignees

@krfricke krfricke

@xwjiang2010 xwjiang2010

Labels
None yet
Projects
None yet
Milestone
Ray AIR
Development

Successfully merging this pull request may close these issues.
4 participants
@Yard1 @richardliaw @xwjiang2010 @krfricke