[AIR] Improve to_air_checkpoint with path
#26532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antoni Baum <[email protected]>
Signed-off-by: Antoni Baum <[email protected]>
Signed-off-by: Antoni Baum <[email protected]>
xwjiang2010
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
Thanks @Yard1! Makes sense as a UX improvement. I have the same concern as the other PR - i.e. the semantics is not exactly clear as to who should be responsible for cleaning the "temporary" directories up.
I like your idea of a context manager, but not sure how that would work for other to_air_checkpoint (e.g. those not relying on a path) - maybe a no-op.
Ok to leave as a future followup.
xwjiang2010
approved these changes
Jul 14, 2022
xwjiang2010
pushed a commit
to xwjiang2010/ray
that referenced
this pull request
Jul 19, 2022
Signed-off-by: Xiaowei Jiang <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antoni Baum [email protected]
Why are these changes needed?
Clarifies the API for
to_air_checkpoint.Related issue number
Checks
scripts/format.shto lint the changes in this PR.