Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIR] Use cls in from_checkpoint #26534

Merged
merged 2 commits into from
Jul 14, 2022
Merged

[AIR] Use cls in from_checkpoint #26534

merged 2 commits into from
Jul 14, 2022

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Jul 13, 2022

Signed-off-by: Antoni Baum [email protected]

Why are these changes needed?

Uses cls in from_checkpoint classmethods for better subclass development experience.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Yard1 Yard1 added this to the Ray AIR milestone Jul 13, 2022
amogkam
amogkam approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Yard1, also ran into this issue during my dogfooding as well :)

@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jul 14, 2022
@ericl ericl merged commit 8f74e1f into ray-project:master Jul 14, 2022
@Yard1 Yard1 deleted the from_checkpoint_improvement branch July 14, 2022 08:46
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
@Yard1
[AIR] Use cls in from_checkpoint (ray-project#26534)
a84d702 
Uses `cls` in `from_checkpoint` classmethods for better subclass development experience.

Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amogkam amogkam amogkam approved these changes

@ericl ericl ericl approved these changes

@richardliaw richardliaw Awaiting requested review from richardliaw

@krfricke krfricke Awaiting requested review from krfricke

Assignees

@ericl ericl

@richardliaw richardliaw

@amogkam amogkam

Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Milestone
Ray AIR
Development

Successfully merging this pull request may close these issues.
4 participants
@Yard1 @ericl @amogkam @richardliaw