[air/tuner] Expose number of errored/terminated trials in ResultGrid #26655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
|
Can you also somehow capture the exception and traceback? The number of failed trials is not as useful if you can't debug the trial failures |
|
Users have access to this via or These contain the full exceptions. I can implement a shortcut for this, e.g. |
Signed-off-by: Kai Fricke <[email protected]>
richardliaw
approved these changes
Jul 18, 2022
xwjiang2010
pushed a commit
to xwjiang2010/ray
that referenced
this pull request
Jul 19, 2022
…ay-project#26655) This introduces an easy interface to retrieve the number of errored and terminated (non-errored) trials from the result grid. Previously `tune.run(raise_on_failed_trial)` could be used to raise a TuneError if at least one trial failed. We've removed this option to make sure we always get a return value. `ResultGrid.num_errored` will make it easy for users to identify if trials failed and react to it instead of the old try-catch loop. Signed-off-by: Kai Fricke <[email protected]> Signed-off-by: Xiaowei Jiang <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
…ay-project#26655) This introduces an easy interface to retrieve the number of errored and terminated (non-errored) trials from the result grid. Previously `tune.run(raise_on_failed_trial)` could be used to raise a TuneError if at least one trial failed. We've removed this option to make sure we always get a return value. `ResultGrid.num_errored` will make it easy for users to identify if trials failed and react to it instead of the old try-catch loop. Signed-off-by: Kai Fricke <[email protected]> Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kai Fricke [email protected]
Why are these changes needed?
This introduces an easy interface to retrieve the number of errored and terminated (non-errored) trials from the result grid.
Previously
tune.run(raise_on_failed_trial)could be used to raise a TuneError if at least one trial failed. We've removed this option to make sure we always get a return value.ResultGrid.num_erroredwill make it easy for users to identify if trials failed and react to it instead of the old try-catch loop.Related issue number
Checks
scripts/format.shto lint the changes in this PR.