[Serve] Promote graceful shutdown and health check #26682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-mo
reviewed
Jul 19, 2022
sihanwang41
requested review from
edoakes,
jiaodong and
shrekris-anyscale
as code owners
done! |
simon-mo
reviewed
Jul 19, 2022
simon-mo
approved these changes
Jul 19, 2022
edoakes
reviewed
Jul 21, 2022
There was a problem hiding this comment.
@sihanwang41 there is a note on the docs page, please remove it:
:::{note}
User-defined health checks are experimental and may be subject to change before the interface is stabilized. If you have any feedback or run into any issues or unexpected behaviors, please file an issue on GitHub.
:::
Then LGTM.
edoakes
added
the
@author-action-required
Rohan138
pushed a commit
to Rohan138/ray
that referenced
this pull request
Jul 28, 2022
Signed-off-by: Rohan138 <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.