[Dashboard] Actor Table UI Optimize #26785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…"" This reverts commit e542899.
Conflicts: dashboard/client/src/type/actor.ts
alanwguo
requested changes
Jul 20, 2022
| import copy from "copy-to-clipboard"; | ||
| import React, { useState } from "react"; | ||
|
|
||
| const CopyableCollapse: React.FC<{ |
There was a problem hiding this comment.
seems like this could be handled by pure css instead.
display: block
text-overflow: ellipsis
text-wrap: nowrap
overflow: hidden
width: 50px
You can see an example here (see idCol css class):
This css rule will cut off the text after 50px but if a user selects it and copies it, it will copy the entire string.
|
@alanwguo Take a look again or approve? |
alanwguo
approved these changes
Jul 24, 2022
| @@ -210,17 +194,28 @@ const ActorTable = ({ | |||
| } | |||
| key={actorId} | |||
| > | |||
| <TableCell align="center"> | |||
| {/* <div className={classes.idCol}>{actorId}</div> */} | |||
There was a problem hiding this comment.
left this comment in by accident?
There was a problem hiding this comment.
I forgot to delete, thx.
|
|
SongGuyang
added
the
tests-ok
This was referenced Jul 25, 2022
This was referenced Jul 25, 2022
Rohan138
pushed a commit
to Rohan138/ray
that referenced
this pull request
Jul 28, 2022
Co-authored-by: 多牧 <[email protected]> Signed-off-by: Rohan138 <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
Co-authored-by: 多牧 <[email protected]> Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Copy from #16071.
The related PR #15802.