Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datasets] Add AWS CLI info into S3 credential error message #26789

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

c21
Copy link
Contributor

@c21 c21 commented Jul 20, 2022

Why are these changes needed?

As followup of #26669 (comment), we want to add AWS CLI command information into S# credential error message, so users have a better idea to further debug the read issue.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@c21 c21 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jul 21, 2022
@clarkzinzow clarkzinzow merged commit 94d50e7 into ray-project:master Jul 21, 2022
@c21 c21 deleted the s3 branch July 21, 2022 17:25
Rohan138 pushed a commit to Rohan138/ray that referenced this pull request Jul 28, 2022
…oject#26789)

As followup of ray-project#26669 (comment), we want to add AWS CLI command information into S# credential error message, so users have a better idea to further debug the read issue.

Signed-off-by: Rohan138 <[email protected]>
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
…oject#26789)

As followup of ray-project#26669 (comment), we want to add AWS CLI command information into S# credential error message, so users have a better idea to further debug the read issue.

Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants