-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIR] Predictor call_model
API for unsupported output types
#26845
Merged
ericl
merged 10 commits into
ray-project:master
from
amogkam:predictor-developer-prototype
Jul 27, 2022
Merged
[AIR] Predictor call_model
API for unsupported output types
#26845
ericl
merged 10 commits into
ray-project:master
from
amogkam:predictor-developer-prototype
Jul 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amog Kamsetty <[email protected]>
Signed-off-by: Amog Kamsetty <[email protected]>
Signed-off-by: Amog Kamsetty <[email protected]>
ericl
reviewed
Jul 21, 2022
ericl
reviewed
Jul 21, 2022
ericl
added
the
@author-action-required
The PR author is responsible for the next step. Remove tag to send back to the reviewer.
label
Jul 21, 2022
Signed-off-by: Amog Kamsetty <[email protected]>
…ictor-developer-prototype Signed-off-by: Amog Kamsetty <[email protected]>
Signed-off-by: Amog Kamsetty <[email protected]>
…ictor-developer-prototype
Signed-off-by: Amog Kamsetty <[email protected]>
amogkam
removed
the
@author-action-required
The PR author is responsible for the next step. Remove tag to send back to the reviewer.
label
Jul 27, 2022
amogkam
changed the title
[WIP] Predictor Developer API prototype
[AIR] Predictor Jul 27, 2022
call_model
API for unsupported output types
Signed-off-by: Amog Kamsetty <[email protected]>
Signed-off-by: Amog Kamsetty <[email protected]>
clarkzinzow
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice examples in the call_model()
docstrings!
6 tasks
Rohan138
pushed a commit
to Rohan138/ray
that referenced
this pull request
Jul 28, 2022
…oject#26845) Signed-off-by: Rohan138 <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
…oject#26845) Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amog Kamsetty [email protected]
Adds a Public
call_model
API toTorchPredictor
andTensorflowPredictor
.We also remove default support for List outputs, as it's ambiguous if the list represents the batch, or different output columns.
Supported output types are
tensor
andDict[str, tensor]
.To handle models with unsupported output types, users are expected to override
call_model
.Example:
Documentation will be added if this API looks good.
Why are these changes needed?
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.