-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Put learning test into own folders #26862
Conversation
Signed-off-by: avnish <[email protected]>
Signed-off-by: avnish <[email protected]>
@avnishn Would like to underline that the release tests in their individual folders have oversized clusters to run on. Hence the PR was tagged "do-not-merge"! |
My plan is the increase the amount of cpus/gpus each algorithm is using to decrease learning time. In a separate PR. For now, this is good to merge to unblock the release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am actually a big fan of this change.
so most of these 2gpu compute configs can be changed to 1gpu right?
Co-authored-by: Artur Niederfahrenhorst <[email protected]> Signed-off-by: Rohan138 <[email protected]>
Co-authored-by: Artur Niederfahrenhorst <[email protected]> Signed-off-by: Stefan van der Kleij <[email protected]>
Learning tests A-E are failing and we need to find out whether that's because of competition for resources.
This PR puts them onto their own clusters to see what happens.
Closes #26731 . @ArturNiederfahrenhorst for whatever reason I couldn't push to your branch after running gh pr checkout so I had to reopen this my bad
Why are these changes needed?
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.