Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Put learning test into own folders #26862

Merged
merged 11 commits into from
Jul 22, 2022

Conversation

avnishn
Copy link
Member

@avnishn avnishn commented Jul 22, 2022

Learning tests A-E are failing and we need to find out whether that's because of competition for resources.
This PR puts them onto their own clusters to see what happens.

Closes #26731 . @ArturNiederfahrenhorst for whatever reason I couldn't push to your branch after running gh pr checkout so I had to reopen this my bad

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@avnishn avnishn linked an issue Jul 22, 2022 that may be closed by this pull request
@ArturNiederfahrenhorst
Copy link
Contributor

@avnishn Would like to underline that the release tests in their individual folders have oversized clusters to run on. Hence the PR was tagged "do-not-merge"!

@avnishn
Copy link
Member Author

avnishn commented Jul 22, 2022

My plan is the increase the amount of cpus/gpus each algorithm is using to decrease learning time. In a separate PR.

For now, this is good to merge to unblock the release.

Copy link
Member

@gjoliver gjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am actually a big fan of this change.
so most of these 2gpu compute configs can be changed to 1gpu right?

@richardliaw richardliaw merged commit 82395c4 into ray-project:master Jul 22, 2022
Rohan138 pushed a commit to Rohan138/ray that referenced this pull request Jul 28, 2022
Co-authored-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Rohan138 <[email protected]>
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
Co-authored-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RLlib Release Tests] Learning Tests a-e and f-z are failing
5 participants