[State Observability] Warn if callsite is disabled when ray list objects + raise exception on missing output
#26880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickyyx
approved these changes
Jul 22, 2022
| @@ -2423,6 +2424,101 @@ def verify(): | |||
| wait_for_condition(verify) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("callsite_enabled", [True, False]) | |||
| def test_callsite_warning(callsite_enabled, monkeypatch, shutdown_only): | |||
|
Mostly nits only. Looks like there is another dependent test failure due to API change: test_dashboard_requests_fail_on_missing_deps https://buildkite.com/ray-project/ray-builders-pr/builds/39517#_ |
rickyyx
added
the
@author-action-required
Rohan138
pushed a commit
to Rohan138/ray
that referenced
this pull request
Jul 28, 2022
…ects` + raise exception on missing output (ray-project#26880) This PR does 3 things. 1. Warn if callsite is disabled when `ray list objects` and `ray summary objects` 2. Decode owner_id for ray list actors 3. Support raise_on_missing_output Signed-off-by: Rohan138 <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
…ects` + raise exception on missing output (ray-project#26880) This PR does 3 things. 1. Warn if callsite is disabled when `ray list objects` and `ray summary objects` 2. Decode owner_id for ray list actors 3. Support raise_on_missing_output Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR does 3 things.
ray list objectsandray summary objectsRelated issue number
Closes #26005
Closes
Checks
scripts/format.shto lint the changes in this PR.