-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[air/tune] Add top-level imports for Tuner, TuneConfig, move CheckpointConfig #26882
[air/tune] Add top-level imports for Tuner, TuneConfig, move CheckpointConfig #26882
Conversation
…ntConfig Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you Kai!
Linter is currently failing:
@ericl can you advise? |
Those are valid linter checks. I would make a PR to move util.client to an _internal package, or otherwise avoid depending on that package for now. |
Should we also add "ResultGrid" to top level? |
I'm going to try reverting the change to |
This reverts commit 95701be.
Signed-off-by: Richard Liaw <[email protected]>
Signed-off-by: Richard Liaw <[email protected]>
…ntConfig (ray-project#26882) Signed-off-by: Rohan138 <[email protected]>
…ntConfig (ray-project#26882) Signed-off-by: Stefan van der Kleij <[email protected]>
Signed-off-by: Kai Fricke [email protected]
Why are these changes needed?
This exposes Tuner and TuneConfig to the top-level ray.tune scope and moves checkpoint config to ray.air.config. This PR fixes circular imports.
Related issue number
Closes #24703
Checks
scripts/format.sh
to lint the changes in this PR.