Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[air/tune] Add top-level imports for Tuner, TuneConfig, move CheckpointConfig #26882

Merged
merged 7 commits into from
Jul 23, 2022

Conversation

krfricke
Copy link
Contributor

Signed-off-by: Kai Fricke [email protected]

Why are these changes needed?

This exposes Tuner and TuneConfig to the top-level ray.tune scope and moves checkpoint config to ray.air.config. This PR fixes circular imports.

Related issue number

Closes #24703

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Kai Fricke <[email protected]>
@krfricke krfricke marked this pull request as ready for review July 22, 2022 15:48
Copy link
Contributor

@xwjiang2010 xwjiang2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you Kai!

@krfricke
Copy link
Contributor Author

Linter is currently failing:

ray.util.client.common.ActorOptionWrapper
ray.util.client.common.ClientActorClass
ray.util.client.common.ClientActorHandle
ray.util.client.common.ClientActorRef
ray.util.client.common.ClientObjectRef
ray.util.client.common.ClientRemoteFunc
ray.util.client.common.ClientRemoteMethod
ray.util.client.common.ClientServerHandle
ray.util.client.common.ClientSideRefID
ray.util.client.common.ClientStub
ray.util.client.common.InProgressSentinel
ray.util.client.common.OptionWrapper
ray.util.client.common.OrderedResponseCache
ray.util.client.common.ResponseCache
ray.util.client.common.remote_decorator
ray.util.client.common.return_refs
ray.util.client.common.set_task_options
ray.util.client.options.validate_options
ray.util.placement_group.check_placement_group_index

@ericl can you advise?

@ericl
Copy link
Contributor

ericl commented Jul 22, 2022

Those are valid linter checks. I would make a PR to move util.client to an _internal package, or otherwise avoid depending on that package for now.

@xwjiang2010
Copy link
Contributor

Should we also add "ResultGrid" to top level?

@richardliaw
Copy link
Contributor

I'm going to try reverting the change to util to unblock this PR; we can remove clean it up from util separately.

@richardliaw richardliaw merged commit 1f32cb9 into ray-project:master Jul 23, 2022
@krfricke krfricke deleted the air/top-level-imports branch July 23, 2022 07:40
Rohan138 pushed a commit to Rohan138/ray that referenced this pull request Jul 28, 2022
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants