[RLlib]: Raise deprecation warning in MARWIL OPE methods #26893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohan138 <[email protected]>
Signed-off-by: Rohan138 <[email protected]>
Signed-off-by: Rohan138 <[email protected]>
Signed-off-by: Rohan138 <[email protected]>
Rohan138
requested review from
sven1977,
gjoliver,
avnishn,
ArturNiederfahrenhorst,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
Signed-off-by: Rohan138 <[email protected]>
| # TODO: Remove this when the off_polciy_estimation_methods | ||
| # default config is removed from MARWIL | ||
| # No off-policy estimation. | ||
| self.off_policy_estimation_methods = {} |
ArturNiederfahrenhorst
approved these changes
Jul 23, 2022
|
Nope, but there might be a few minor changes once we actually do the eventual deprecation. |
Rohan138
added a commit
to Rohan138/ray
that referenced
this pull request
Jul 28, 2022
…t#26893) Signed-off-by: Rohan138 <[email protected]>
Rohan138
added a commit
to Rohan138/ray
that referenced
this pull request
Jul 28, 2022
…t#26893) Signed-off-by: Rohan138 <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
…t#26893) Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MARWIL currently uses
off_policy_estimation_methods = {"is": {"type": ImportanceSampling}, "wis": {"type": WeightedImportanceSampling}}by default instead of {} like all of the other algorithms. This should be deprecated and removed in a future release. We can't just remove it because of users that may be using MARWIL with the current default.Closes #26667
Checks
scripts/format.shto lint the changes in this PR.