[core] runtime context resource ids getter #26907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Liaw <[email protected]>
Signed-off-by: Richard Liaw <[email protected]>
richardliaw
added
the
core-interface-change-approval-required
|
Note that we should absolutely get this in for 2.0 (to clean up the XGBoost experience). |
scv119
approved these changes
Jul 22, 2022
scv119
reviewed
Jul 22, 2022
jjyao
reviewed
Jul 22, 2022
python/ray/runtime_context.py
Outdated
| """Get the assigned resources to this worker. | ||
|
|
||
| Returns: | ||
| A dictionary mapping the name of a resource to a list of pairs, where |
There was a problem hiding this comment.
I think we should return a dict mapping from resource name to count. Id of the resource is only meaningful for GPU and we already have a ray.worker.get_gpu_ids() for that purpose. Also feel we should copy get_gpu_ids() into runtime context as well for consistency.
There was a problem hiding this comment.
Good point. I updated and added a docstring. Can you take a look?
I also won't address the get_gpu_ids() thing since we should probably have a broader discussion there (get_gpu_ids() is frequently used in multiple libraries?)
jjyao
added
the
@author-action-required
Signed-off-by: Richard Liaw <[email protected]>
richardliaw
removed
the
@author-action-required
jovany-wang
reviewed
Jul 23, 2022
Signed-off-by: Richard Liaw <[email protected]>
Signed-off-by: Richard Liaw <[email protected]>
Signed-off-by: Richard Liaw <[email protected]>
Signed-off-by: Richard Liaw <[email protected]>
jovany-wang
approved these changes
Jul 24, 2022
pcmoritz
approved these changes
Jul 24, 2022
krfricke
pushed a commit
to ray-project/xgboost_ray
that referenced
this pull request
Jul 25, 2022
Following ray-project/ray#26907, we can now avoid a deprecation message when using XGBRay with 2.0. Signed-off-by: Richard Liaw <[email protected]>
Rohan138
pushed a commit
to Rohan138/ray
that referenced
this pull request
Jul 28, 2022
Signed-off-by: Rohan138 <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We’re seeing a deprecation message from XGBoost Ray:
DeprecationWarning:
ray.worker.get_resource_idsis a private attribute and access will be removed in a future Ray version.and we use this function call in two places for XGboost:
To set the right OMP_NUM_THREADS per actor (=num cpus assigned to the actor).
Configuring the right number of threads for the XGBoost model (=num cpus per worker).
The current workaround will be to thread the num_cpus_per_worker configuration from the driver through all the actors, but ideally (1) would be configured for us.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.