-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[air/tuner/docs] Update docs for Tuner() API 1: RSTs, docs, move reuse_actors #26930
Merged
scv119
merged 6 commits into
ray-project:master
from
krfricke:air/doc/tuner-non-notebooks
Jul 24, 2022
Merged
[air/tuner/docs] Update docs for Tuner() API 1: RSTs, docs, move reuse_actors #26930
scv119
merged 6 commits into
ray-project:master
from
krfricke:air/doc/tuner-non-notebooks
Jul 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_actors Signed-off-by: Kai Fricke <[email protected]>
krfricke
requested review from
richardliaw,
xwjiang2010,
amogkam,
matthewdeng,
Yard1,
maxpumperla,
sven1977,
gjoliver,
avnishn,
ArturNiederfahrenhorst,
smorad,
kouroshHakha,
ericl,
scv119,
clarkzinzow,
jjyao,
jianoaix,
pcmoritz,
edoakes and
simon-mo
as code owners
July 23, 2022 17:10
6 tasks
Signed-off-by: Xiaowei Jiang <[email protected]>
Signed-off-by: xwjiang2010 <[email protected]>
Signed-off-by: xwjiang2010 <[email protected]>
richardliaw
approved these changes
Jul 24, 2022
sven1977
approved these changes
Jul 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Looks good to me (only checked the RLlib parts!). |
ArturNiederfahrenhorst
approved these changes
Jul 24, 2022
scv119
approved these changes
Jul 24, 2022
Rohan138
pushed a commit
to Rohan138/ray
that referenced
this pull request
Jul 28, 2022
…e_actors (ray-project#26930) Signed-off-by: Kai Fricke [email protected] Why are these changes needed? Splitting up ray-project#26884: This PR includes changes to use Tuner() instead of tune.run() for most docs files (rst and py), and a change to move reuse_actors to the TuneConfig Signed-off-by: Rohan138 <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
…e_actors (ray-project#26930) Signed-off-by: Kai Fricke [email protected] Why are these changes needed? Splitting up ray-project#26884: This PR includes changes to use Tuner() instead of tune.run() for most docs files (rst and py), and a change to move reuse_actors to the TuneConfig Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kai Fricke [email protected]
Why are these changes needed?
Splitting up #26884: This PR includes changes to use Tuner() instead of tune.run() for most docs files (rst and py), and a change to move reuse_actors to the TuneConfig
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.