Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[air/tuner/docs] Update docs for Tuner() API 1: RSTs, docs, move reuse_actors #26930

Merged
merged 6 commits into from
Jul 24, 2022

Conversation

krfricke
Copy link
Contributor

Signed-off-by: Kai Fricke [email protected]

Why are these changes needed?

Splitting up #26884: This PR includes changes to use Tuner() instead of tune.run() for most docs files (rst and py), and a change to move reuse_actors to the TuneConfig

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sven1977
Copy link
Contributor

Looks good to me (only checked the RLlib parts!).
Thanks @krfricke !

@scv119 scv119 merged commit 8fe4399 into ray-project:master Jul 24, 2022
@krfricke krfricke deleted the air/doc/tuner-non-notebooks branch July 24, 2022 17:17
Rohan138 pushed a commit to Rohan138/ray that referenced this pull request Jul 28, 2022
…e_actors (ray-project#26930)

Signed-off-by: Kai Fricke [email protected]

Why are these changes needed?
Splitting up ray-project#26884: This PR includes changes to use Tuner() instead of tune.run() for most docs files (rst and py), and a change to move reuse_actors to the TuneConfig


Signed-off-by: Rohan138 <[email protected]>
@zhe-thoughts zhe-thoughts added the docs An issue or change related to documentation label Jul 30, 2022
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
…e_actors (ray-project#26930)

Signed-off-by: Kai Fricke [email protected]

Why are these changes needed?
Splitting up ray-project#26884: This PR includes changes to use Tuner() instead of tune.run() for most docs files (rst and py), and a change to move reuse_actors to the TuneConfig

Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs An issue or change related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants