[Nightly] fix microbenchmark scripts #26947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: scv119 <[email protected]>
matthewdeng
approved these changes
Jul 24, 2022
release/release_tests.yaml
Outdated
| @@ -3413,7 +3413,7 @@ | |||
|
|
|||
| run: | |||
| timeout: 1800 | |||
| script: OMP_NUM_THREADS=64 RAY_ADDRESS= python run_microbenchmark.py | |||
| script: OMP_NUM_THREADS=64 RAY_ADDRESS=auto python run_microbenchmark.py | |||
There was a problem hiding this comment.
Any ideas why this worked before?
There was a problem hiding this comment.
probably because of this pr 55a0f7b
Rohan138
pushed a commit
to Rohan138/ray
that referenced
this pull request
Jul 28, 2022
Signed-off-by: scv119 [email protected] Why are these changes needed? microbenchmarks failed complaining raise ValueError(f"Malformed address: {address}") ValueError: Malformed address: this is due to 55a0f7b and fix it by set RAY_ADDRESS="local" Signed-off-by: Rohan138 <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
Signed-off-by: scv119 [email protected] Why are these changes needed? microbenchmarks failed complaining raise ValueError(f"Malformed address: {address}") ValueError: Malformed address: this is due to 55a0f7b and fix it by set RAY_ADDRESS="local" Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: scv119 [email protected]
Why are these changes needed?
microbenchmarks failed complaining
fix it by set RAY_ADDRESS="local"
Related issue number
Checks
scripts/format.shto lint the changes in this PR.