[AIR] Add __repr__ to AIR classes
#27006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bveeramani
requested review from
ericl,
scv119,
clarkzinzow,
jjyao and
jianoaix
as code owners
richardliaw
reviewed
Jul 26, 2022
richardliaw
reviewed
Jul 26, 2022
richardliaw
reviewed
Jul 26, 2022
| @@ -209,6 +209,10 @@ def __init__( | |||
| self._uri: Optional[str] = uri | |||
| self._obj_ref: Optional[ray.ObjectRef] = obj_ref | |||
|
|
|||
| def __repr__(self): | |||
richardliaw
reviewed
Jul 26, 2022
richardliaw
reviewed
Jul 26, 2022
richardliaw
reviewed
Jul 26, 2022
bveeramani
commented
Jul 26, 2022
Comment on lines
+101
to
+115
| default_values = { | ||
| "output_column_name": "concat_out", | ||
| "include": None, | ||
| "exclude": [], | ||
| "dtype": None, | ||
| "raise_if_missing": False, | ||
| } | ||
|
|
||
| non_default_arguments = [] | ||
| for parameter, default_value in default_values.items(): | ||
| value = getattr(self, parameter) | ||
| if value != default_value: | ||
| non_default_arguments.append(f"{parameter}={value}") | ||
|
|
||
| return f"{self.__class__.__name__}({', '.join(non_default_arguments)})" |
There was a problem hiding this comment.
Added this so the representation isn't too long.
richardliaw
approved these changes
Jul 26, 2022
richardliaw
approved these changes
Jul 27, 2022
ericl
previously requested changes
Jul 27, 2022
Fixed |
clarkzinzow
approved these changes
Jul 27, 2022
Signed-off-by: Richard Liaw <[email protected]>
bveeramani
added a commit
to bveeramani/ray
that referenced
this pull request
Aug 4, 2022
7 tasks
matthewdeng
pushed a commit
that referenced
this pull request
Aug 5, 2022
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
These changes are needed to improve the UX in interactive sessions and Jupyter notebooks.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.