Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] CRR framework torch by default. #27161

Merged

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jul 28, 2022

Switch on framework="torch" by default for CRR. CRR only supports torch thus far.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <[email protected]>
@scv119
Copy link
Contributor

scv119 commented Aug 8, 2022

is it still to be picked? no activity for 11 days

@scv119 scv119 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Aug 8, 2022
@sven1977 sven1977 merged commit 537f7c6 into ray-project:master Aug 9, 2022
@scv119
Copy link
Contributor

scv119 commented Aug 12, 2022

@sven1977 @kouroshHakha cherry pick to releases/2.0.0 branch?

@kouroshHakha
Copy link
Contributor

@scv119 yes please.

Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
@sven1977 sven1977 deleted the crr_framework_torch_by_default branch June 2, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants