[train/horovod] Fix horovod long running release test #27179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reporting only on checkpoint Signed-off-by: Kai Fricke <[email protected]>
xwjiang2010
reviewed
Jul 28, 2022
xwjiang2010
approved these changes
Jul 28, 2022
xwjiang2010
changed the title
|
Marking as no merge as the test is still failing. If you continue on this please remove when appropriate @xwjiang2010 - otherwise I'll take a look in mid August |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
stale
bot
added
the
stale
added 2 commits
September 12, 2022 09:03
stale
bot
removed
the
stale
Signed-off-by: Kai Fricke <[email protected]>
|
Depends on #28440 and should report more frequently |
added 2 commits
September 13, 2022 11:33
Signed-off-by: Kai Fricke <[email protected]>
|
The test is now working as expected (perturbing configs and correctly restarting from checkpoints). Merging. |
stephanie-wang
added a commit
that referenced
this pull request
Sep 13, 2022
This reverts commit 4b59dfb.
stephanie-wang
added a commit
that referenced
this pull request
Sep 13, 2022
…" (#28476) This reverts commit 4b59dfb. Looks like this breaks linux://python/ray/air:horovod_cifar_pbt_example Signed-off-by: Stephanie Wang [email protected]
krfricke
added a commit
that referenced
this pull request
Sep 13, 2022
PaulFenton
pushed a commit
to PaulFenton/ray
that referenced
this pull request
Sep 19, 2022
…oject#27179)" (ray-project#28476) This reverts commit 4b59dfb. Looks like this breaks linux://python/ray/air:horovod_cifar_pbt_example Signed-off-by: Stephanie Wang [email protected] Signed-off-by: PaulFenton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kai Fricke [email protected]
Why are these changes needed?
The long running horovod release test only ever stays at 1 iteration for each trial. The reason for this is that it PAUSES trials to give way to other trials - but the trials only checkpoint at the end of each epoch. We have to either increase the pertubation interval massively, or report at the end of the epoch. Here I decided for the latter.
Related issue number
Addresses part of #27165
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.