[AIR] Change FeatureHasher input schema
#27523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bveeramani
requested review from
ericl,
scv119,
clarkzinzow,
jjyao and
jianoaix
as code owners
matthewdeng
reviewed
Aug 5, 2022
matthewdeng
approved these changes
Aug 5, 2022
bveeramani
added
v2.0.0-pick
tests-ok
richardliaw
reviewed
Aug 8, 2022
Comment on lines
+66
to
+73
| .. seealso:: | ||
| :class:`~ray.data.preprocessors.CountVectorizer` | ||
| Use this preprocessor to generate inputs for :class:`FeatureHasher`. | ||
|
|
||
| :class:`ray.data.preprocessors.HashingVectorizer` | ||
| If your input data describes documents rather than token frequencies, | ||
| use :class:`~ray.data.preprocessors.HashingVectorizer`. | ||
| """ # noqa: E501 |
There was a problem hiding this comment.
nice ! we should do this way more.
richardliaw
approved these changes
Aug 8, 2022
bveeramani
added a commit
to bveeramani/ray
that referenced
this pull request
Aug 8, 2022
…-project#27523) This makes FeatureHasher work more like sklearn's FeatureHasher.
7 tasks
matthewdeng
pushed a commit
that referenced
this pull request
Aug 8, 2022
) (#27675) This makes FeatureHasher work more like sklearn's FeatureHasher.
scottsun94
pushed a commit
to scottsun94/ray
that referenced
this pull request
Aug 9, 2022
…-project#27523) This makes FeatureHasher work more like sklearn's FeatureHasher. Signed-off-by: Huaiwei Sun <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
…-project#27523) This makes FeatureHasher work more like sklearn's FeatureHasher. Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
See #27505.
Related issue number
Fixes #27505
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.