Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIR - Datasets] Fix column assignment in Concatenator for Pandas 1.2. #27531

Merged

Conversation

clarkzinzow
Copy link
Contributor

Heterogeneous tensor column assignment with a list-of-tensors fails for Pandas 1.2, but succeeds with a manually constructed Pandas Series.

Related issue number

Fixes #27503

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

python/setup.py Outdated Show resolved Hide resolved
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the Tune change?

@clarkzinzow
Copy link
Contributor Author

clarkzinzow commented Aug 6, 2022

MacOS tests passed on previous run and Windows wheel build is fixed, merging.

@clarkzinzow clarkzinzow merged commit f017fcd into ray-project:master Aug 6, 2022
clarkzinzow added a commit to clarkzinzow/ray that referenced this pull request Aug 6, 2022
ray-project#27531)

Heterogeneous tensor column assignment with a list-of-tensors fails for Pandas 1.2, but succeeds with a manually constructed Pandas Series.
scv119 pushed a commit that referenced this pull request Aug 6, 2022
#27531) (#27596)

Heterogeneous tensor column assignment with a list-of-tensors fails for Pandas 1.2, but succeeds with a manually constructed Pandas Series.
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
ray-project#27531)

Heterogeneous tensor column assignment with a list-of-tensors fails for Pandas 1.2, but succeeds with a manually constructed Pandas Series.

Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[air/preprocessors] Concatenator doesn't work for pandas==1.2.1
6 participants