[RLlib] Require ApeX LR schedule test to produce learner info #27557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
ArturNiederfahrenhorst
requested review from
sven1977,
gjoliver,
avnishn,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
| @@ -124,6 +124,8 @@ def test_apex_lr_schedule(self): | |||
| ) | |||
| .reporting( | |||
| min_sample_timesteps_per_iteration=10, | |||
| # Make sure that results contain info on default policy | |||
| min_train_timesteps_per_iteration=10, | |||
There was a problem hiding this comment.
In L141, we require results to contain info on default policy.
There was a problem hiding this comment.
we can probably remove l126 then.
If we need to merge quickly though then not necessary to make the change.
There was a problem hiding this comment.
Sure! I've tested removing L126 now and it ends up messing with the way we test the LR here. So we should merge as is.
avnishn
approved these changes
Aug 5, 2022
scottsun94
pushed a commit
to scottsun94/ray
that referenced
this pull request
Aug 9, 2022
…roject#27557) Signed-off-by: Huaiwei Sun <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
…roject#27557) Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artur Niederfahrenhorst [email protected]
Why are these changes needed?
Ape-X LR schedule test can fail if an iteration does include learning on samples.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.