[air] Render trainer docstring signatures #27590
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Because we override
__new__
, we can't render signatures correctly, losing valuable type hints. This is a one-off fix to improve this by rendering the init method manually, but it is not a great fix. Ideally we get rid of our usage of__new__
and render things correctly.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.