Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset] Pin _StatsActor to the driver node #27765

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Aug 10, 2022

Signed-off-by: Jiajun Yao [email protected]

Why are these changes needed?

Similar to what's done in #23397

This allows the actor to fate-share with the driver and tolerate worker node failures.

Related issue number

Closes #27752

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@clarkzinzow clarkzinzow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@scv119 scv119 merged commit 27e38f8 into ray-project:master Aug 11, 2022
scv119 pushed a commit that referenced this pull request Aug 11, 2022
Similar to what's done in #23397

This allows the actor to fate-share with the driver and tolerate worker node failures.
scv119 pushed a commit that referenced this pull request Aug 11, 2022
Similar to what's done in #23397

This allows the actor to fate-share with the driver and tolerate worker node failures.
@jjyao jjyao deleted the jjyao/pin branch August 11, 2022 05:33
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
Similar to what's done in ray-project#23397

This allows the actor to fate-share with the driver and tolerate worker node failures.

Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.0rc1][Nightly] chaos_dataset_shuffle_sort_1tb failed
5 participants