[Datasets] Customized serializer for Arrow JSON ParseOptions in read_json #27911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cheng Su <[email protected]>
c21
requested review from
ericl,
scv119,
clarkzinzow,
jjyao and
jianoaix
as code owners
c21
added
the
tests-ok
|
Checked the failed test is not related to the change here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cheng Su [email protected]
Why are these changes needed?
This PR is to add customized serializer of Arrow JSON ParseOptions for
read_json. We found user wanted to read JSON file withParseOptions, but it's currently not working due to pickle issue (detail of post). So here we add a customized serializer forParseOptionsas a workaround for now, similar to #25821.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.