Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIR][Docs] Set logging_strategy="epoch" for HF (#27917) #27955

Merged
merged 1 commit into from
Aug 17, 2022
Merged

[AIR][Docs] Set logging_strategy="epoch" for HF (#27917) #27955

merged 1 commit into from
Aug 17, 2022

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Aug 17, 2022

Why are these changes needed?

Fixes Hugging Face examples failing with latest HF Transformers release. This is a docs/examples only change.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Yard1 Yard1 requested a review from matthewdeng August 17, 2022 16:31
@matthewdeng matthewdeng merged commit d3c231d into ray-project:releases/2.0.0 Aug 17, 2022
@Yard1 Yard1 deleted the cp_hf_set_logging_strategy branch August 17, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdeng matthewdeng matthewdeng approved these changes

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

@pcmoritz pcmoritz Awaiting requested review from pcmoritz pcmoritz is a code owner

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@dmatrix dmatrix Awaiting requested review from dmatrix dmatrix is a code owner

@sriram-anyscale sriram-anyscale Awaiting requested review from sriram-anyscale sriram-anyscale is a code owner

@richardliaw richardliaw Awaiting requested review from richardliaw richardliaw is a code owner

Assignees

@matthewdeng matthewdeng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yard1 @matthewdeng