Cap the number of stats kept in StatsActor and purge in FIFO order if the limit exceeded #27964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jianoaix <[email protected]>
jianoaix
requested review from
ericl,
scv119,
clarkzinzow and
jjyao
as code owners
ericl
requested changes
Aug 17, 2022
jianoaix
changed the title
|
@ericl suggestion adopted. PTAL, thanks. |
ericl
reviewed
Aug 18, 2022
python/ray/data/_internal/stats.py
Outdated
|
|
||
| TODO(ekl) we should consider refactoring LazyBlockList so stats can be | ||
| extracted without using an out-of-band actor.""" | ||
|
|
||
| def __init__(self): | ||
| def __init__(self, max_stats=100 * 1000): |
There was a problem hiding this comment.
Reduced to 10k. IIRC there were people talking about number of blocks above 1000, so set it 10k for safety (it won't take significant amount of bytes anyway).
There was a problem hiding this comment.
Hm it looks uuid is per Dataset not per block, lowering down to 1k.
| # Add the fourth stats to exceed the limit. | ||
| actor.record_start.remote(3) | ||
| # The first stats (with uuid=0) should have been purged. | ||
| assert ray.get(actor.get.remote(0))[0] == {} |
There was a problem hiding this comment.
An even stronger test would be to query the internal dict sizes, to verify the deletion actually happened.
There was a problem hiding this comment.
Added a private method to the StatsActor to query the dict sizes.
ericl
added
the
@author-action-required
jianoaix
removed
the
@author-action-required
ericl
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jianoaix [email protected]
Why are these changes needed?
There is a risk of using too much of memory in StatsActor, because its lifetime is the same as cluster lifetime.
This puts a cap on how many stats to keep, and purge the stats in FIFO order if this cap is exceeded.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.