Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] quick fix for learning rate schedule for APPO algorithm. #28013

Merged
merged 2 commits into from
Aug 19, 2022

Conversation

gjoliver
Copy link
Member

Why are these changes needed?

LearningRateSchedule must be initialized after base.init() call.
Longer term, base classes should rely as little as possible on class member variables.
E.g., all these base modules could have simply taken config as input when necessary.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [*] Unit tests
    • Release tests
    • This PR is not tested :(

@avnishn
Copy link
Member

avnishn commented Aug 19, 2022

will need to check whether the appo vtrace failing test is related or is flaking

@gjoliver
Copy link
Member Author

will need to check whether the appo vtrace failing test is related or is flaking

yeah, good call, I am gonna do it now.

Signed-off-by: Jun Gong <[email protected]>
@gjoliver
Copy link
Member Author

will need to check whether the appo vtrace failing test is related or is flaking

yeah, good call, I am gonna do it now.

doesn't seem related. the test also doesn't use lr schedule at all.

@richardliaw richardliaw merged commit ec38b96 into ray-project:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants