Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIR][Docs] Clarify how LGBM/XGB trainers work #28122

Merged
merged 4 commits into from
Aug 26, 2022

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Aug 26, 2022

Signed-off-by: Antoni Baum [email protected]

Why are these changes needed?

Users are sometimes confused by how XGBoost/LightGBM training on Ray works, and how much is changed/added by Ray. This docstring note clarifies this.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Yard1 Yard1 added this to the Ray AIR milestone Aug 26, 2022
Signed-off-by: Antoni Baum <[email protected]>
Signed-off-by: Antoni Baum <[email protected]>
@richardliaw richardliaw merged commit ea483ec into ray-project:master Aug 26, 2022
@Yard1 Yard1 deleted the air_xgb_lgbm_docstring branch August 27, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants