Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[workflow] Change name in step to task_id #28151

Merged
merged 1 commit into from
Sep 1, 2022
Merged

[workflow] Change name in step to task_id #28151

merged 1 commit into from
Sep 1, 2022

Conversation

fishbone
Copy link
Contributor

Why are these changes needed?

We've deprecated the name options and use task_id. This is the cleanup to fix everything left.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@fishbone fishbone requested review from maxpumperla and a team as code owners August 30, 2022 05:54
suquark
suquark approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@suquark suquark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@fishbone
sign
e0cc4f6 
Signed-off-by: Yi Cheng <[email protected]>
@fishbone fishbone merged commit d0b879c into ray-project:master Sep 1, 2022
XiaodongLv pushed a commit to XiaodongLv/ray that referenced this pull request Sep 2, 2022
@fishbone
[workflow] Change name in step to task_id (ray-project#28151)
8302593 
We've deprecated the name options and use task_id. This is the cleanup to fix everything left.
ilee300a pushed a commit to ilee300a/ray that referenced this pull request Sep 12, 2022
@fishbone @ilee300a
[workflow] Change name in step to task_id (ray-project#28151)
00fd533 
We've deprecated the name options and use task_id. This is the cleanup to fix everything left.

Signed-off-by: ilee300a <[email protected]>
matthewdeng pushed a commit that referenced this pull request Sep 15, 2022
@fishbone @matthewdeng
[workflow] Change name in step to task_id (#28151)
9bfc2e9 
We've deprecated the name options and use task_id. This is the cleanup to fix everything left.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suquark suquark suquark approved these changes

@ericl ericl Awaiting requested review from ericl

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

Assignees

@suquark suquark

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fishbone @suquark