Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIR] [Docs] Fix TorchCheckpoint docstring example #28189

Merged

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Aug 30, 2022

Signed-off-by: Balaji Veeramani [email protected]

Why are these changes needed?

The example for TorchCheckpoint.from_state_dict incorrectly used from_model instead of from_state_dict.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a small PR description please?

@amogkam
Copy link
Contributor

amogkam commented Sep 2, 2022

Thanks @bveeramani! can you merge in master and add a sign off and we can merge this in?

@amogkam amogkam merged commit cb0c91b into ray-project:master Sep 7, 2022
ilee300a pushed a commit to ilee300a/ray that referenced this pull request Sep 12, 2022
Signed-off-by: Balaji Veeramani [email protected]

The example for TorchCheckpoint.from_state_dict incorrectly used from_model instead of from_state_dict.

Signed-off-by: ilee300a <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants