[RLlib] Create connectors when calling add_policy #28201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
ArturNiederfahrenhorst
requested review from
sven1977,
gjoliver,
avnishn,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
gjoliver
reviewed
Aug 31, 2022
rllib/evaluation/rollout_worker.py
Outdated
| @@ -1252,6 +1252,9 @@ def add_policy( | |||
|
|
|||
| self.filters[policy_id] = get_filter(self.observation_filter, filter_shape) | |||
|
|
|||
| if self.policy_config.get("enable_connectors") and policy_id in self.policy_map: | |||
There was a problem hiding this comment.
can you check if self.policy_map[policy_id] already has connectors configured?
when you restore a connector-enabled policy, existing connector state is part of the policy state, so it should be restore already, and we don't need to create things from fresh here.
and I think the logic right now is that you can't really restore non-connector policies for a connector-enabled stack.
There was a problem hiding this comment.
Done!
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
ilee300a
pushed a commit
to ilee300a/ray
that referenced
this pull request
Sep 12, 2022
…-project#28201) Signed-off-by: ilee300a <[email protected]>
justinvyu
pushed a commit
to justinvyu/ray
that referenced
this pull request
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artur Niederfahrenhorst [email protected]
Why are these changes needed?
Currently, connectors are not added when manually adding a policy to a rollout worker after worker initialization.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.