[RLlib] Make Connectorpipeline indexable #28202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
ArturNiederfahrenhorst
requested review from
sven1977,
gjoliver,
avnishn,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
ArturNiederfahrenhorst
changed the title
gjoliver
reviewed
Aug 31, 2022
rllib/connectors/connector.py
Outdated
| results.append(c) | ||
|
|
||
| if len(results) == 0: | ||
| raise IndexError |
There was a problem hiding this comment.
can we simply return empty [] instead of raising error?
it feels like a common use case for someone to want to check whether a specific connector is configured for current pipeline, if not, create it.
There was a problem hiding this comment.
Got it!
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
ArturNiederfahrenhorst
force-pushed
the
ConnectorPipelineget
branch
from
bdb9436
to
29ca5b0
Compare
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
gjoliver
reviewed
Sep 1, 2022
rllib/connectors/connector.py
Outdated
| results.append(c) | ||
|
|
||
| if len(results) == 0: | ||
| raise [] |
There was a problem hiding this comment.
Wow. Sorry!
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
sven1977
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
LGTM, thanks for the enhancement @ArturNiederfahrenhorst and your review @gjoliver !
ilee300a
pushed a commit
to ilee300a/ray
that referenced
this pull request
Sep 12, 2022
…able by int or class (or classname). (ray-project#28202) Signed-off-by: ilee300a <[email protected]>
justinvyu
pushed a commit
to justinvyu/ray
that referenced
this pull request
Sep 14, 2022
…able by int or class (or classname). (ray-project#28202)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artur Niederfahrenhorst [email protected]
Why are these changes needed?
As per Jun's request, connector pipelines should be indexable.
This PR makes it so that they are indexable by class, class name or an integer number.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.