[Doc] [Tune] Fix tune resources user guide example code #28210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <[email protected]>
justinvyu
requested review from
richardliaw,
krfricke,
xwjiang2010,
amogkam,
matthewdeng,
Yard1,
maxpumperla and
a team
as code owners
|
Awesome! Thanks Justin! |
xwjiang2010
approved these changes
Aug 31, 2022
|
This can be done in a followup PR, but can we move those snippets to doccode, so it can be tested in CI? |
krfricke
approved these changes
Aug 31, 2022
matthewdeng
reviewed
Sep 1, 2022
Comment on lines
+116
to
+118
| # We choose to use a `PlacementGroupFactory` here to specify trial resources | ||
| resource_group = tune.PlacementGroupFactory([{"CPU": 2, "GPU": 1}]) | ||
| trainable_with_resources = tune.with_resources(trainable, resource_group) |
There was a problem hiding this comment.
nit: I know this was already like this, but is there reason why this one doesn't just use a dictionary?
XiaodongLv
pushed a commit
to XiaodongLv/ray
that referenced
this pull request
Sep 2, 2022
The tune resources user guide contained broken code snippets. This PR fixes those, adds some extra clarifying comments, and improves the code style for readability. Signed-off-by: Justin Yu <[email protected]>
ilee300a
pushed a commit
to ilee300a/ray
that referenced
this pull request
Sep 12, 2022
The tune resources user guide contained broken code snippets. This PR fixes those, adds some extra clarifying comments, and improves the code style for readability. Signed-off-by: Justin Yu <[email protected]> Signed-off-by: ilee300a <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The tune resources user guide contained broken code snippets. This PR fixes those, adds some extra clarifying comments, and improves the code style for readability.
Related issue number
Closes #28206
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.