[Runtime Environment] Parse special characters in private Git URIs #28250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Users can access private Git repos via runtime environments by specifying an archive link, usually containing a username and private token. For example, from the Ray documentation, the GitHub format is
However, the colon (
:
) and at (@
) symbols are not removed before parsing the URI as a directory name for the runtime environment. Since PYTHONPATHs use colons as package name separators, Python modules in this private repo can't be imported.This change converts the colon and at symbols to underscores (
_
) when converting the URI into a directory name. This allows modules stored in private repos to be imported.Related issue number
N/A
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.test_runtime_env_packaging.py
.