Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIR] Add default prefetch to tf dataset in AIR examples #28306

Merged
merged 3 commits into from
Sep 7, 2022
Merged

[AIR] Add default prefetch to tf dataset in AIR examples #28306

merged 3 commits into from
Sep 7, 2022

Conversation

jiaodong
Copy link
Member

@jiaodong jiaodong commented Sep 6, 2022 •
edited
Loading

Signed-off-by: Jiao Dong [email protected]

Why are these changes needed?

We should recommend better practice in our tf examples.

Related issue number

#28241

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jiaodong jiaodong marked this pull request as ready for review September 6, 2022 16:54
@jiaodong jiaodong requested a review from a team as a code owner September 6, 2022 16:54
@amogkam
Copy link
Contributor

amogkam commented Sep 7, 2022

Actually @jiaodong should we just automatically do this in prepare_dataset_shard?

@amogkam amogkam changed the title Add default prefetch to tf dataset in AIR examples [AIR] Add default prefetch to tf dataset in AIR examples Sep 7, 2022
@amogkam
Copy link
Contributor

amogkam commented Sep 7, 2022 •
edited
Loading

@jiaodong can you add a sign off for this (just add it to the PR description)?

@jiaodong
Copy link
Member Author

jiaodong commented Sep 7, 2022

@amogkam added (i usually just click on the DCO from github ui lol)

@amogkam amogkam merged commit 114a05a into ray-project:master Sep 7, 2022
ilee300a pushed a commit to ilee300a/ray that referenced this pull request Sep 12, 2022
@jiaodong @ilee300a
[AIR] Add default prefetch to tf dataset in AIR examples (ray-project…
0492a6b 
…#28306)

We should recommend better practice in our tf examples.

Signed-off-by: Jiao Dong [email protected]
Signed-off-by: ilee300a <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amogkam amogkam amogkam approved these changes

@ericl ericl ericl approved these changes

@richardliaw richardliaw Awaiting requested review from richardliaw

@matthewdeng matthewdeng Awaiting requested review from matthewdeng matthewdeng is a code owner

Assignees

@matthewdeng matthewdeng

@richardliaw richardliaw

@amogkam amogkam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jiaodong @amogkam @ericl @matthewdeng @richardliaw