Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Fix gym.spaces.Box receiving TensorDims from RLlib as shape (instead or list of ints). #28334

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Sep 7, 2022

Signed-off-by: sven1977 [email protected]

Fix gym.spaces.Box receiving TensorDims from RLlib as shape (instead or list of ints).

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <[email protected]>
Copy link
Contributor

@ArturNiederfahrenhorst ArturNiederfahrenhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sven1977 sven1977 merged commit acda25d into ray-project:master Sep 8, 2022
ilee300a pushed a commit to ilee300a/ray that referenced this pull request Sep 12, 2022
justinvyu pushed a commit to justinvyu/ray that referenced this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants