-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] Add maxTaskRetries option for java actor creation #28377
Conversation
@jovany-wang I reopened this pr, sorry for the inconvenience |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the contribution.
Signed-off-by: Zhi Lin <[email protected]>
@kira-lin Could you add a unit test case? |
@kfstorm Do java tests have the utility (like ClusterUtils in python) to test object recovery? I didn't find a way to lose an object in plasma in java tests. Plus, this pr just opens the option for users, the function is implemented in ray core, and is tested in python. |
Could you try copying |
OK. I was thinking about testing resubmitting actor task during object reconstruction, because that's our use case. |
Signed-off-by: Zhi Lin <[email protected]>
Signed-off-by: Zhi Lin <[email protected]>
@kfstorm ci passed |
Signed-off-by: Zhi Lin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Signed-off-by: Zhi Lin <[email protected]>
@ericl @raulchen @WangTaoTheTonic @iycheng Could you please take a look and merge it if possible, appreciated |
Signed-off-by: Zhi Lin [email protected]
Why are these changes needed?
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.