Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Add maxTaskRetries option for java actor creation #28377

Merged
merged 5 commits into from
Sep 19, 2022

Conversation

kira-lin
Copy link
Contributor

@kira-lin kira-lin commented Sep 8, 2022

Signed-off-by: Zhi Lin [email protected]

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@kira-lin
Copy link
Contributor Author

kira-lin commented Sep 8, 2022

@jovany-wang I reopened this pr, sorry for the inconvenience

Copy link
Contributor

@jovany-wang jovany-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the contribution.

@kfstorm
Copy link
Member

kfstorm commented Sep 9, 2022

@kira-lin Could you add a unit test case?

@kira-lin
Copy link
Contributor Author

kira-lin commented Sep 9, 2022

@kfstorm Do java tests have the utility (like ClusterUtils in python) to test object recovery? I didn't find a way to lose an object in plasma in java tests. Plus, this pr just opens the option for users, the function is implemented in ray core, and is tested in python.

@kfstorm
Copy link
Member

kfstorm commented Sep 9, 2022

@kfstorm Do java tests have the utility (like ClusterUtils in python) to test object recovery? I didn't find a way to lose an object in plasma in java tests. Plus, this pr just opens the option for users, the function is implemented in ray core, and is tested in python.

Could you try copying test_actor_restart_with_retry into Java? I don't see any special logic about deleting objects in plasma.

@kira-lin
Copy link
Contributor Author

kira-lin commented Sep 9, 2022

OK. I was thinking about testing resubmitting actor task during object reconstruction, because that's our use case.

Signed-off-by: Zhi Lin <[email protected]>
Signed-off-by: Zhi Lin <[email protected]>
@kira-lin
Copy link
Contributor Author

@kfstorm ci passed

Signed-off-by: Zhi Lin <[email protected]>
Copy link
Member

@kfstorm kfstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Signed-off-by: Zhi Lin <[email protected]>
@kira-lin
Copy link
Contributor Author

@ericl @raulchen @WangTaoTheTonic @iycheng Could you please take a look and merge it if possible, appreciated

@jovany-wang jovany-wang merged commit 7280ef4 into ray-project:master Sep 19, 2022
@kira-lin kira-lin deleted the java-retry-2 branch September 20, 2022 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants