-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Add lr_schedule support to SimpleQ and PG. #28381
[RLlib] Add lr_schedule support to SimpleQ and PG. #28381
Conversation
Signed-off-by: mgerstgrasser <[email protected]>
458000e
to
581dfab
Compare
Thanks for this PR! I'm adding some testing and minor stuff and then we can have a review and merge :) |
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Oh thank you! Anything I can do to help? |
Not for now, thanks! @sven1977 will have to review next. |
Hey @mgerstgrasser , thanks for the PR! This looks great. I'm getting this error here: |
Signed-off-by: mgerstgrasser <[email protected]>
89ef796
to
06ae8c4
Compare
@sven1977 Should be fixed now, thanks for flagging this. Issue was in the test - it's passing a PG config into BC. I'm just removing the |
Signed-off-by: mgerstgrasser <[email protected]>
Signed-off-by: PaulFenton <[email protected]>
Why are these changes needed?
SimpleQ and PG currently don't support a learning rate schedule. SimpleQ does list a
lr_schedule
key in its default config, but will simply ignore it, which could lead to user confusion. PG does not accept alr_schedule
key, but there is no reason why it shouldn't support a learning rate schedule.Related issue number
Closes #28266
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.