-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Activate dataset doctests #28395
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcmoritz
requested review from
ericl,
scv119,
clarkzinzow,
jjyao,
jianoaix and
c21
as code owners
September 9, 2022 04:08
pcmoritz
commented
Sep 9, 2022
maxpumperla
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great! thanks so much
maxpumperla
approved these changes
Sep 9, 2022
scv119
approved these changes
Sep 10, 2022
7 tasks
ilee300a
pushed a commit
to ilee300a/ray
that referenced
this pull request
Sep 12, 2022
After ray-project#28368 we can now reactivate the dataset doctests! Signed-off-by: ilee300a <[email protected]>
justinvyu
pushed a commit
to justinvyu/ray
that referenced
this pull request
Sep 14, 2022
After ray-project#28368 we can now reactivate the dataset doctests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
After #28368 we can now reactivate the dataset doctests!
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.