Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Activate dataset doctests #28395

Merged
merged 13 commits into from
Sep 10, 2022
Merged

Conversation

pcmoritz
Copy link
Contributor

@pcmoritz pcmoritz commented Sep 9, 2022

Why are these changes needed?

After #28368 we can now reactivate the dataset doctests!

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@maxpumperla maxpumperla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! thanks so much

@pcmoritz pcmoritz merged commit 601a5b7 into ray-project:master Sep 10, 2022
@pcmoritz pcmoritz deleted the dataset-doctests branch September 10, 2022 20:35
@bveeramani bveeramani mentioned this pull request Sep 11, 2022
7 tasks
ilee300a pushed a commit to ilee300a/ray that referenced this pull request Sep 12, 2022
After ray-project#28368 we can now reactivate the dataset doctests!

Signed-off-by: ilee300a <[email protected]>
justinvyu pushed a commit to justinvyu/ray that referenced this pull request Sep 14, 2022
After ray-project#28368 we can now reactivate the dataset doctests!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants