[tune/rllib] Ignore directory exists errors to tackle race conditions #28401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Fricke <[email protected]>
krfricke
requested review from
sven1977,
gjoliver,
avnishn,
ArturNiederfahrenhorst,
smorad,
maxpumperla and
kouroshHakha
as code owners
ArturNiederfahrenhorst
approved these changes
Sep 9, 2022
ilee300a
pushed a commit
to ilee300a/ray
that referenced
this pull request
Sep 12, 2022
…ray-project#28401) Rollout workers can run into race conditions when creating directories - with this PR we ignore existing directory errors on `os.makedirs` in various locations in tune/rllib. Signed-off-by: Kai Fricke <[email protected]> Signed-off-by: ilee300a <[email protected]>
justinvyu
pushed a commit
to justinvyu/ray
that referenced
this pull request
Sep 14, 2022
…ray-project#28401) Rollout workers can run into race conditions when creating directories - with this PR we ignore existing directory errors on `os.makedirs` in various locations in tune/rllib. Signed-off-by: Kai Fricke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kai Fricke [email protected]
Why are these changes needed?
Rollout workers can run into race conditions when creating directories - with this PR we ignore existing directory errors on
os.makedirsin various locations in tune/rllib.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.