Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the peak memory usage calculation #28419

Merged
merged 1 commit into from
Sep 10, 2022

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Sep 10, 2022

Signed-off-by: jianoaix [email protected]

Why are these changes needed?

"x / c * c" is still x, so it will make the stats off.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ericl ericl merged commit 9fcfbc9 into ray-project:master Sep 10, 2022
ilee300a pushed a commit to ilee300a/ray that referenced this pull request Sep 12, 2022
justinvyu pushed a commit to justinvyu/ray that referenced this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants