[tune] Fix trial cleanup after x seconds, set default to 600 #28449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 12, 2022 19:03
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
krfricke
requested review from
richardliaw,
xwjiang2010,
amogkam,
matthewdeng,
Yard1,
maxpumperla and
a team
as code owners
krfricke
changed the title
xwjiang2010
approved these changes
Sep 13, 2022
added 2 commits
September 13, 2022 10:04
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
added 2 commits
September 13, 2022 15:06
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
richardliaw
approved these changes
Sep 13, 2022
added 2 commits
September 13, 2022 18:47
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
PaulFenton
pushed a commit
to PaulFenton/ray
that referenced
this pull request
Sep 19, 2022
…ject#28449) This currently does not work in three places: 1) We need to kill the actor as garbage collection will not work with futures in flight, 2) We need to trigger the _stop_actor method after clearing the futures, as it will create a new future, 3) the future was not fetched correctly. We also set the default cleanup time to 10 minutes, which should suffice for most cases and avoids deadlocks in long-running tasks. Signed-off-by: Kai Fricke <[email protected]> Signed-off-by: PaulFenton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kai Fricke [email protected]
Why are these changes needed?
This currently does not work in three places: 1) We need to kill the actor as garbage collection will not work with futures in flight, 2) We need to trigger the _stop_actor method after clearing the futures, as it will create a new future, 3) the future was not fetched correctly.
We also set the default cleanup time to 10 minutes, which should suffice for most cases and avoids deadlocks in long-running tasks.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.