Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Clarify dataset transformation. #28482

Merged
merged 12 commits into from
Oct 4, 2022
Merged

[doc] Clarify dataset transformation. #28482

merged 12 commits into from
Oct 4, 2022

Conversation

xwjiang2010
Copy link
Contributor

As surfaced from UX sessions.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

jianoaix
jianoaix reviewed Sep 14, 2022
View reviewed changes
Copy link
Contributor

@jianoaix jianoaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Xiaowei!

doc/source/data/doc_code/transforming_datasets.py Outdated Show resolved Hide resolved
doc/source/data/transforming-datasets.rst Outdated Show resolved Hide resolved
clarkzinzow
clarkzinzow reviewed Sep 14, 2022
View reviewed changes
doc/source/data/doc_code/transforming_datasets.py Outdated Show resolved Hide resolved
doc/source/data/doc_code/transforming_datasets.py Outdated Show resolved Hide resolved
doc/source/data/doc_code/transforming_datasets.py Outdated Show resolved Hide resolved
doc/source/data/doc_code/transforming_datasets.py Outdated Show resolved Hide resolved
doc/source/data/doc_code/transforming_datasets.py Outdated Show resolved Hide resolved
doc/source/data/transforming-datasets.rst Outdated Show resolved Hide resolved
doc/source/data/transforming-datasets.rst Outdated Show resolved Hide resolved
python/ray/data/dataset.py Outdated Show resolved Hide resolved
@jianoaix jianoaix added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Sep 23, 2022
@xwjiang2010
address comments.
15fd361 
Signed-off-by: xwjiang2010 <[email protected]>
@xwjiang2010
typo
7a2345e 
Signed-off-by: xwjiang2010 <[email protected]>
@xwjiang2010 xwjiang2010 removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Sep 29, 2022
clarkzinzow
clarkzinzow reviewed Sep 29, 2022
View reviewed changes
Copy link
Contributor

@clarkzinzow clarkzinzow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits on the code blocks' indentation, not sure if what I did will fix it.

python/ray/data/dataset.py Outdated Show resolved Hide resolved
doc/source/data/transforming-datasets.rst Outdated Show resolved Hide resolved
doc/source/data/transforming-datasets.rst Outdated Show resolved Hide resolved
doc/source/data/transforming-datasets.rst Outdated Show resolved Hide resolved
@xwjiang2010
Address comments
5290347 
Signed-off-by: xwjiang2010 <[email protected]>
@xwjiang2010
Copy link
Contributor Author

@clarkzinzow
Indentation looks ok to me now.
Screen Shot 2022-10-04 at 7 41 19 AM

@xwjiang2010 xwjiang2010 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Oct 4, 2022
clarkzinzow
clarkzinzow approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@clarkzinzow clarkzinzow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only nits left! Thanks for improving these docs! 🙌

doc/source/data/doc_code/transforming_datasets.py Outdated Show resolved Hide resolved
doc/source/data/doc_code/transforming_datasets.py Outdated Show resolved Hide resolved
doc/source/data/doc_code/transforming_datasets.py Outdated Show resolved Hide resolved
doc/source/data/doc_code/transforming_datasets.py Outdated Show resolved Hide resolved
@richardliaw richardliaw merged commit c774aab into ray-project:master Oct 4, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@xwjiang2010 @WeichenXu123
[doc] Clarify dataset transformation. (ray-project#28482)
962caa8 
Signed-off-by: Weichen Xu <[email protected]>
@xwjiang2010 xwjiang2010 deleted the ux_bug_bash branch July 26, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianoaix jianoaix jianoaix approved these changes

@clarkzinzow clarkzinzow clarkzinzow approved these changes

@ericl ericl Awaiting requested review from ericl

@scv119 scv119 Awaiting requested review from scv119

@jjyao jjyao Awaiting requested review from jjyao

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@c21 c21 Awaiting requested review from c21

Assignees

@bveeramani bveeramani

@jianoaix jianoaix

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xwjiang2010 @clarkzinzow @jianoaix @richardliaw @bveeramani