[Doc] [Serve] Add docs for custom resources with Serve #28529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
architkulkarni
requested review from
edoakes,
simon-mo,
jiaodong,
shrekris-anyscale and
sihanwang41
as code owners
There was a problem hiding this comment.
Nice work! Can we also explicitly list
- The
ray_actor_optionsoptions somewhere in the docs (instead of only in the docstring)? - The
acceleratortypes that are allowed? I believe only the accelerators from accelerators.py are allowed. @simon-mo do you know if other accelerators can be used?
sihanwang41
approved these changes
Sep 15, 2022
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Archit Kulkarni <[email protected]>
architkulkarni
added
the
@author-action-required
simon-mo
approved these changes
Sep 15, 2022
|
@shrekris-anyscale Thanks, I've just linked to the existing accelerator doc which seems to say that those are the only available types. Ready for review again |
architkulkarni
removed
the
@author-action-required
architkulkarni
added
the
@author-action-required
architkulkarni
removed
the
@author-action-required
|
@ray-project/ray-docs Could you please give codeowner approval? |
ericl
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
ray_actor_optionsRelated issue number
Closes #28477
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.