Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIR] More modularity for Trainers #28650

Merged
merged 3 commits into from
Sep 21, 2022

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Sep 20, 2022

Signed-off-by: Antoni Baum [email protected]

Why are these changes needed?

Internal refactor to make user/developer subclassing easier for some trainers.

Related issue number

Closes #28616

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Antoni Baum <[email protected]>
Signed-off-by: Antoni Baum <[email protected]>
@Yard1 Yard1 changed the title [AIR] More modularity for Trainers, use session. [AIR] More modularity for Trainers Sep 20, 2022
@Yard1 Yard1 marked this pull request as ready for review September 21, 2022 15:42
@krfricke krfricke merged commit 1e54fff into ray-project:master Sep 21, 2022
@Yard1 Yard1 deleted the air_trainers_more_modularity branch September 21, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AIR] Improve modularity of AIR Trainers (especially GBDT ones)
3 participants