Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] @deprecate(error=True|False) escalation. #28733

Merged
merged 12 commits into from
Sep 26, 2022
Merged

[RLlib] @deprecate(error=True|False) escalation. #28733

merged 12 commits into from
Sep 26, 2022

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Sep 23, 2022 •
edited
Loading

Signed-off-by: sven1977 [email protected]

For already deprecated items (classes, functions, methods, etc..):

  • Escalate some of these from error=False (soft-deprecation) to error=True (hard-deprecate).
  • Escalate some of these from error=True (user still gets a meaningful error) to full removal (in order to clean up code).

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
766d1d0 
Signed-off-by: sven1977 <[email protected]>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into depr…
3d34597 
…ecate_error_false_true_escalation
@sven1977
wip
19aeaf8 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
64d4727 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
1c9927b 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
6a93907 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
e9e64a1 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
d21f15e 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
a38c81c 
Signed-off-by: sven1977 <[email protected]>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into depr…
3c5511b 
…ecate_error_false_true_escalation
@sven1977 sven1977 requested a review from a team as a code owner September 24, 2022 13:07
@sven1977
wip
54486db 
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Sep 25, 2022
@sven1977 sven1977 assigned kouroshHakha and unassigned gjoliver Sep 26, 2022
gjoliver
gjoliver approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@gjoliver gjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, this is a lot of deprecations.
ok, as long as the tests pass I think :)

@sven1977
merge
00d45ee 
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 merged commit c4348c1 into ray-project:master Sep 26, 2022
amogkam added a commit that referenced this pull request Sep 26, 2022
@amogkam
Revert "[RLlib] @deprecate(error=True|False) escalation. (#28733)"
1eae067 
This reverts commit c4348c1.
@amogkam amogkam mentioned this pull request Sep 26, 2022
Merged
amogkam added a commit that referenced this pull request Sep 26, 2022
@amogkam
Revert "[RLlib] @deprecate(error=True|False) escalation. (#28733)" (#…
e501654 
…28795)

Signed-off-by: Amog Kamsetty [email protected]

Reverts #28733

Breaks ray-air/examples:rl_offline_example and ray-air/examples:rl_online_example
amogkam added a commit that referenced this pull request Sep 26, 2022
@amogkam
Revert "Revert "[RLlib] @deprecate(error=True|False) escalation. (#28733
ae3d929 
)" (#28795)"

This reverts commit e501654.
@rickyyx rickyyx mentioned this pull request Oct 26, 2022
Closed
7 tasks
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@sven1977 @WeichenXu123
[RLlib] @deprecate(error=True|False) escalation. (ray-project#28733)
ae07819 
Signed-off-by: Weichen Xu <[email protected]>
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@amogkam @WeichenXu123
Revert "[RLlib] @deprecate(error=True|False) escalation. (ray-project…
3d71c83 
…#28733)" (ray-project#28795)

Signed-off-by: Amog Kamsetty [email protected]

Reverts ray-project#28733

Breaks ray-air/examples:rl_offline_example and ray-air/examples:rl_online_example

Signed-off-by: Weichen Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjoliver gjoliver gjoliver approved these changes

@avnishn avnishn Awaiting requested review from avnishn

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

@smorad smorad Awaiting requested review from smorad

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

@kouroshHakha kouroshHakha Awaiting requested review from kouroshHakha

@krfricke krfricke Awaiting requested review from krfricke

Assignees

@kouroshHakha kouroshHakha

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sven1977 @gjoliver @kouroshHakha