[AIR] More Train and Tune session deprecations #28856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amog Kamsetty <[email protected]>
xwjiang2010
reviewed
Sep 28, 2022
| @@ -204,7 +204,7 @@ def _shutdown(): | |||
| _session = None | |||
|
|
|||
|
|
|||
| @PublicAPI | |||
| @Deprecated(message=_deprecation_msg) | |||
There was a problem hiding this comment.
just checking that this won't print out the message when the method is called right?
It is just reflecting in the doc string?
There was a problem hiding this comment.
yep thats right, this is just in the docstring (which actually won't really matter currently since we no longer show these APIs in the docs anymore).
xwjiang2010
approved these changes
Sep 28, 2022
…ecate-train-session
Signed-off-by: Amog Kamsetty <[email protected]>
|
Failing tests are unrelated, going to merge. |
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
Signed-off-by: Amog Kamsetty [email protected] Finish marking train. and tune. session APIs as deprecated Signed-off-by: Weichen Xu <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amog Kamsetty [email protected]
Finish marking
train.andtune.session APIs as deprecatedWhy are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.