Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Upgrade redis from 6.x to 7.0.5. #28936

Merged
merged 5 commits into from
Oct 1, 2022
Merged

[core] Upgrade redis from 6.x to 7.0.5. #28936

merged 5 commits into from
Oct 1, 2022

Conversation

fishbone
Copy link
Contributor

Signed-off-by: Yi Cheng [email protected]

Why are these changes needed?

Due to the SSL support and also security issues, upgrade the redis from 6.x to 7.0.5.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@fishbone
up
df21675 
Signed-off-by: Yi Cheng <[email protected]>
@fishbone fishbone added the release-blocker P0 Issue that blocks the release label Sep 30, 2022
ijrsvt
ijrsvt approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@ijrsvt ijrsvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fishbone
Copy link
Contributor Author

some test failures. let me check.

scv119
scv119 approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@scv119 scv119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as CI passes

@fishbone
Copy link
Contributor Author

fishbone commented Oct 1, 2022

mac and linux looks good. windows still fails.

@fishbone
fix win
d9462b4 
Signed-off-by: Yi Cheng <[email protected]>
@fishbone
Copy link
Contributor Author

fishbone commented Oct 1, 2022

test failure is not related.

@fishbone fishbone merged commit 6d2faa3 into ray-project:master Oct 1, 2022
matthewdeng pushed a commit that referenced this pull request Oct 3, 2022
@fishbone @matthewdeng
[core] Upgrade redis from 6.x to 7.0.5. (#28936)
5586b38 
Due to the SSL support and also security issues, upgrade the redis from 6.x to 7.0.5.
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@fishbone @WeichenXu123
[core] Upgrade redis from 6.x to 7.0.5. (ray-project#28936)
b23f4df 
Due to the SSL support and also security issues, upgrade the redis from 6.x to 7.0.5.

Signed-off-by: Weichen Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijrsvt ijrsvt ijrsvt approved these changes

@scv119 scv119 scv119 approved these changes

Assignees

@scv119 scv119

@matthewdeng matthewdeng

@ijrsvt ijrsvt

Labels
release-blocker P0 Issue that blocks the release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fishbone @scv119 @ijrsvt @matthewdeng