Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial Bazel BUILD file #2899

Closed
wants to merge 1 commit into from
Closed

Conversation

rsepassi
Copy link
Contributor

Partial BUILD file. Missing: external deps, flatbuffers, and credis

Could serve as a starting point for full conversion (#2887)

@rsepassi rsepassi changed the title Partial BUILD file Partial Bazel BUILD file Sep 17, 2018
@ericl
Copy link
Contributor

ericl commented Sep 17, 2018

Is this buildable as is? I get errors like

ERROR: /home/eric/Desktop/ray-private/BUILD:43:1: //:raylet_lib: invalid label 'THIRDPARTY:boost' in element 10 of attribute 'deps' in 'cc_library' rule: invalid target name 'THIRDPARTY:boost': target names may not contain ':'

Also, I had to create a WORKSPACE file that grabs the go rules:

load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
git_repository(
    name = "io_bazel_rules_go",
        remote = "https://github.com/bazelbuild/rules_go.git",
            commit = "a390e7f7eac912f6e67dc54acf67aa974d05f9c3",
            )
load("@io_bazel_rules_go//go:def.bzl", "go_rules_dependencies", "go_register_toolchains")
go_rules_dependencies()
go_register_toolchains()

@pcmoritz
Copy link
Contributor

Thanks, this is great! How did you handle building arrow/including it into the build?

@rsepassi
Copy link
Contributor Author

rsepassi commented Sep 18, 2018 via email

@rsepassi
Copy link
Contributor Author

Have some comments at the top of the BUILD file re what needs to be done: https://github.com/ray-project/ray/pull/2899/files#diff-96239ee297e0a92ac6ff96a6bc434ef0R5

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8270/
Test PASSed.

@robertnishihara
Copy link
Collaborator

Replacing with #3806 and other subsequent PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants