[Doc] Revamp ray core design patterns doc [11/n]: limit running tasks #29046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: Jiajun Yao <[email protected]>
jianoaix
reviewed
Oct 5, 2022
|
|
||
| .. note:: | ||
|
|
||
| If you submit a finite number of tasks, it's unlikely that you will hit the issue mentioned above since each task only uses a small amount of memory in the queue. |
There was a problem hiding this comment.
"each task" -> "each task spec" (or whatever we call it)?
There was a problem hiding this comment.
task spec is internal implementation details. I feel just calling task is better. WDYT?
There was a problem hiding this comment.
It'd be nice to make it clear the memory usage at this point is only for bookkeeping of tasks, not the memory actually used by tasks.
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: Jiajun Yao <[email protected]>
jianoaix
approved these changes
Oct 5, 2022
Signed-off-by: Jiajun Yao <[email protected]>
|
|
||
| You have a data processing workload that processes each input file independently using Ray :ref:`remote functions <ray-remote-functions>`. | ||
| Since each task needs to load the input data into heap memory and do the processing, running too many of them can cause OOM. | ||
| In this case, you can use the ``memory`` resource to limit the number of concurrently running tasks (usage of other resources like ``num_cpus`` can achieve the same goal as well). |
There was a problem hiding this comment.
Should probably add a note to clarify that memory is a logical resource.
Also, it would be nice to link or mention @clarng's ongoing memory monitor work.
Signed-off-by: Jiajun Yao <[email protected]>
stephanie-wang
approved these changes
Oct 5, 2022
|
|
||
| .. note:: | ||
|
|
||
| There is active work ongoing |
There was a problem hiding this comment.
oops. Yea, I was trying to link to @clarng' work but seems that part of doc is not checked in yet. So I'll leave it out for now.
Signed-off-by: Stephanie Wang <[email protected]>
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: Jiajun Yao <[email protected]>
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…ray-project#29046) Create a new design pattern for limiting the number of running tasks. Also distinguish it from an existing pattern of limiting pending tasks given there are confusions about these two patterns. Signed-off-by: Jiajun Yao <[email protected]> Signed-off-by: Stephanie Wang <[email protected]> Co-authored-by: Stephanie Wang <[email protected]> Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jiajun Yao [email protected]
Why are these changes needed?
Create a new design pattern for limiting the number of running tasks. Also distinguish it from an existing pattern of limiting pending tasks given there are confusions about these two patterns.
Related issue number
#27048
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.